Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
bryce-anderson committed Dec 20, 2024
1 parent 1e2e770 commit d77549f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
*
* @param <ResolvedAddress> The resolved address type.
* @param <C> The type of connection.
* @deprecated use {@link DelegatingLoadBalancerBuilder} instead.
*/
@Deprecated // FIXME: 0.43 - Remove in favor of the DefaultLoadBalancer types
public class DelegatingRoundRobinLoadBalancerBuilder<ResolvedAddress, C extends LoadBalancedConnection>
implements RoundRobinLoadBalancerBuilder<ResolvedAddress, C> {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
*
* @param <ResolvedAddress> The resolved address type.
* @param <C> The type of connection.
* @deprecated this class will be made package-private in the future, use {@link RoundRobinLoadBalancers} to create
* @deprecated use {@link LoadBalancers} to create {@link LoadBalancerFactory} instances.
* {@link RoundRobinLoadBalancerBuilder}.
*/
@Deprecated // FIXME: 0.43 - remove in favor of DefaultLoadBalancer types.
Expand Down Expand Up @@ -107,10 +107,9 @@ public String toString() {
*
* @param <ResolvedAddress> The resolved address type.
* @param <C> The type of connection.
* @deprecated this class will be made package-private in the future, rely on the
* {@link RoundRobinLoadBalancerBuilder} instead.
* @deprecated rely on the {@link LoadBalancerBuilder} instead.
*/
@Deprecated // FIXME: 0.43 - Remove in favor of the DefaultLoadBalancer types.
@Deprecated // FIXME: 0.43 - Remove in favor of the DefaultLoadBalancer types
public static final class Builder<ResolvedAddress, C extends LoadBalancedConnection>
implements RoundRobinLoadBalancerBuilder<ResolvedAddress, C> {
private final String id;
Expand All @@ -126,9 +125,9 @@ public static final class Builder<ResolvedAddress, C extends LoadBalancedConnect
/**
* Creates a new instance with default settings.
*
* @deprecated use {@link RoundRobinLoadBalancers#builder(String)} instead.
* @deprecated use {@link LoadBalancers#builder(String)} instead.
*/
@Deprecated // FIXME: 0.43 - remove deprecated constructor
@Deprecated
public Builder() {
this("undefined");
}
Expand Down

0 comments on commit d77549f

Please sign in to comment.