Publisher#takeUntil cancel before terminate #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Publisher#takeUntil will terminate downstream before cancelling upstream. There are some sources (e.g. NettyChannelPublisher) that allow resubscribe in a sequential fashion, but in order for this to work cancellation must be first. Modifications: - Switch ordering in TakeUtil to cancel before terminate - Add TestResubscribePublisher utility that wraps TestPublisher which allows for sequential resbuscribes.
Scottmitch
commented
Nov 7, 2022
| * @return A {@link Publisher} that only emits the items till {@code until} {@link Completable} is completed. | ||
| * @see <a href="https://reactivex.io/documentation/operators/takeuntil.html">ReactiveX takeUntil operator.</a> | ||
| */ | ||
| public final Publisher<T> takeUntil(Supplier<? extends Completable> untilSupplier) { |
There was a problem hiding this comment.
@idelpivnitskiy - I know we have had discussion about providing Supplier vs using defer(() -> ..) in the past. We could continue to assume folks know they should use defer(() -> ..) but in this case it was missed in internal usage and when Completable terminates the Publisher is also terminated, which may trigger re-subscribe... so this state is directly related to termination.
There was a problem hiding this comment.
discussed offline ... Publisher.defer(() -> ..) can be used as a building block in this case. we can add followup docs/examples to clarify making operators that may retain state re-subscribe safe.
|
test failure attributed to #2414 |
|
merging as no API changes and discussed offline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher#takeUntil will terminate downstream before cancelling upstream. There are some sources (e.g. NettyChannelPublisher) that allow resubscribe in a sequential fashion, but in order for this to work cancellation must be first.
Modifications: