Apply optimized execution strategy for converted connections #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When client is converted to a different API, the API optimizes default strategy. We should do the same when we convert a reserved connection to a different API. Modifications: - Apply an execution strategy inside request method of every `ReservedStreamingHttpConnectionToReserved*HttpConnection`; Result: Converted connections apply the same strategy as converted clients.
idelpivnitskiy
commented
Jun 30, 2023
| @@ -144,6 +145,7 @@ public <T> BlockingIterable<? extends T> transportEventIterable(final HttpEventK | |||
|
|
|||
| @Override | |||
| public HttpResponse request(final HttpRequest request) throws Exception { | |||
| request.context().putIfAbsent(HTTP_EXECUTION_STRATEGY_KEY, strategy); | |||
There was a problem hiding this comment.
Sorry, I don't have cycles right now to deal with ClientEffectiveStrategyTest.
I've verified locally that it works as expected after my fix and filed #2635.
The idea is that the request method for every ReservedStreamingHttpConnectionToReserved*HttpConnection should behave the same way as its top-level StreamingHttpClientTo*HttpClient.
There was a problem hiding this comment.
can you add some comments clarifying why and maybe an internal static utility function that makes it easier to track?
Scottmitch
approved these changes
Jun 30, 2023
| @@ -144,6 +145,7 @@ public <T> BlockingIterable<? extends T> transportEventIterable(final HttpEventK | |||
|
|
|||
| @Override | |||
| public HttpResponse request(final HttpRequest request) throws Exception { | |||
| request.context().putIfAbsent(HTTP_EXECUTION_STRATEGY_KEY, strategy); | |||
There was a problem hiding this comment.
can you add some comments clarifying why and maybe an internal static utility function that makes it easier to track?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a client is converted to a different API, the API optimizes the default strategy. We should do the same when we convert a reserved connection to a different API.
Modifications:
ReservedStreamingHttpConnectionToReserved*HttpConnection;Result:
Converted connections apply the same strategy as converted clients.