Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancer: rename NewRoundRobinLoadBalancer to DefaultLoadBalancer #2763

Merged

Conversation

bryce-anderson
Copy link
Contributor

Motivation:

We want to use P2C with the new load balancer system but it currently has 'RoundRobin' in the name.

Modifications:

  • rename NewRoundRobinLoadBalancer to DefaultLoadBalancer
  • add the HostSelector as a constructor param to DefaultLoadBalancer
  • rename some symbols in it to reflect their units

Motivation:

We want to use P2C with the new load balancer system but it
currently has 'RoundRobin' in the name.

Modifications:

- rename NewRoundRobinLoadBalancer to DefaultLoadBalancer
- rename some symbols in it to reflect their units
@bryce-anderson
Copy link
Contributor Author

A motivator for this PR is to slim down #2749.

@bryce-anderson bryce-anderson changed the title Rename NewRoundRobinLoadBalancer to DefaultLoadBalancer loadbalancer: rename NewRoundRobinLoadBalancer to DefaultLoadBalancer Nov 18, 2023
@bryce-anderson bryce-anderson merged commit b656538 into apple:main Nov 27, 2023
15 checks passed
@bryce-anderson bryce-anderson deleted the bl_anderson/defaultloadbalancer branch November 27, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants