loadblancer: HostSelector List variance #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The HostSelector currently operates on a List<Host> which doesn't allow us to pass in lists of refined types. This means we need to make copies of lists just to pass them through if implementations want to store the refined types. Modifications: - Make the HostSelector operate on a List<? extends Host>. This continues to give implementations the ability to read the list entries, which is all it should do, while allowing users of the HostSelector to pass in a list of a refined type.
tkountis
approved these changes
Jan 8, 2024
idelpivnitskiy
approved these changes
Jan 8, 2024
mgodave
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The HostSelector currently operates on a List which doesn't allow us to pass in lists of refined types. This means we need to make copies of lists just to pass them through if implementations want to store the refined types.
Modifications: