loadbalancer: Simplify ConnectionFactory usage in DefaultHost #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We currently use the ConnectionFactory in two places in DefaultHost: - creating new connections - health checking Each of them has to go through the trouble of trying to add the newly created connection to the connection pool and making sure the state remains coherent. Modifications: DefaultHosts health checking feature now uses the `Host.newConnection` method instead of using the factory directly. This lets it get the connection management benefit already in `DefaultHost.newConnection`. It also makes the path to extracting the health check a bit easier to follow. Result: What is the result of this change?
idelpivnitskiy
approved these changes
Jan 11, 2024
bryce-anderson
deleted the
bl_anderson/DefaultHost_connectionFactoryUsage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We currently use the ConnectionFactory in two places in DefaultHost:
Each of them has to go through the trouble of trying to add the newly
created connection to the connection pool and making sure the state
remains coherent.
Modifications:
DefaultHosts health checking feature now uses the
Host.newConnectionmethod instead of using the factory directly.
Results:
Using the
Host.newConnection(..)method lets us reuse the connectionmanagement properties already in
DefaultHost.newConnection. It alsomakes the path to extracting the health check from
DefaultHosta biteasier to envision.