Add utility for common validation patterns for Numbers
#2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We have an agreed pattern for validating numbers, but we repeat the same code in all places instead of having a single utility to handle those. Modifications: - Add `NumberUtils` to `servicetalk-utils-internal`; - Use this utility for all number validation use-cases; Result: Less code duplication, consistent validation.
bryce-anderson
approved these changes
Jan 11, 2024
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TakeNPublisher.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/H2ProtocolConfigBuilder.java
Outdated
Show resolved
Hide resolved
tkountis
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have an agreed pattern for validating numbers, but we repeat the same code in all places instead of having a single utility to handle those.
Modifications:
NumberUtilstoservicetalk-utils-internal;Result:
Less code duplication, consistent validation.