Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancer: deprecate RoundRobinLoadBalancer types #3149

Merged
merged 4 commits into from
Dec 20, 2024
Merged

loadbalancer: deprecate RoundRobinLoadBalancer types #3149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e2e770
loadbalancer: deprecate RoundRobinLoadBalancer types
bryce-anderson Dec 19, 2024
d77549f
feedback
bryce-anderson Dec 20, 2024
4a0400f
Merge remote-tracking branch 'origin/main' into bl_anderson/Deprecate…
bryce-anderson Dec 20, 2024
1294078
better doc still
bryce-anderson Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...cetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
* @param <ResolvedAddress> The resolved address type.
* @param <C> The type of connection.
*/
// FIXME: 0.43 - remove deprecated class
final class RoundRobinLoadBalancer<ResolvedAddress, C extends LoadBalancedConnection>
implements TestableLoadBalancer<ResolvedAddress, C> {

Expand Down
3 changes: 3 additions & 0 deletions ...loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancerBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@
* @param <ResolvedAddress> The resolved address type.
* @param <C> The type of connection.
* @see RoundRobinLoadBalancers
* @deprecated use {@link LoadBalancerBuilder} interfaces instead.
*/
// FIXME: 0.43 - remove deprecated interface
@Deprecated
public interface RoundRobinLoadBalancerBuilder<ResolvedAddress, C extends LoadBalancedConnection> {
bryce-anderson marked this conversation as resolved.
Show resolved Hide resolved

/**
Expand Down
4 changes: 3 additions & 1 deletion ...ncer/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancerBuilderProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@

/**
* Provider for {@link RoundRobinLoadBalancerBuilder} that can be registered using {@link java.util.ServiceLoader}.
* @deprecated use the {@link LoadBalancerBuilder} implementations along with {@link LoadBalancerBuilderProvider}
*/
public interface RoundRobinLoadBalancerBuilderProvider {
@Deprecated
public interface RoundRobinLoadBalancerBuilderProvider { // FIXME: 0.43 - remove deprecated interface

/**
* Returns a {@link RoundRobinLoadBalancerBuilder} based on the pre-initialized
Expand Down
4 changes: 2 additions & 2 deletions ...loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
* @deprecated this class will be made package-private in the future, use {@link RoundRobinLoadBalancers} to create
bryce-anderson marked this conversation as resolved.
Show resolved Hide resolved
* {@link RoundRobinLoadBalancerBuilder}.
*/
@Deprecated // FIXME: 0.43 - make package private
@Deprecated // FIXME: 0.43 - remove in favor of DefaultLoadBalancer types.
public final class RoundRobinLoadBalancerFactory<ResolvedAddress, C extends LoadBalancedConnection>
implements LoadBalancerFactory<ResolvedAddress, C> {

Expand Down Expand Up @@ -110,7 +110,7 @@ public String toString() {
* @deprecated this class will be made package-private in the future, rely on the
* {@link RoundRobinLoadBalancerBuilder} instead.
bryce-anderson marked this conversation as resolved.
Show resolved Hide resolved
*/
@Deprecated // FIXME: 0.43 - make package private
@Deprecated // FIXME: 0.43 - Remove in favor of the DefaultLoadBalancer types.
public static final class Builder<ResolvedAddress, C extends LoadBalancedConnection>
bryce-anderson marked this conversation as resolved.
Show resolved Hide resolved
implements RoundRobinLoadBalancerBuilder<ResolvedAddress, C> {
private final String id;
Expand Down
6 changes: 5 additions & 1 deletion ...etalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@

/**
* A factory to create {@link RoundRobinLoadBalancer RoundRobinLoadBalancers}.
* @deprecated use {@link LoadBalancers} instead.
*/
public final class RoundRobinLoadBalancers {
@Deprecated
public final class RoundRobinLoadBalancers { // FIXME: 0.43 - remove deprecated class
private static final Logger LOGGER = LoggerFactory.getLogger(RoundRobinLoadBalancers.class);

private static final List<RoundRobinLoadBalancerBuilderProvider> PROVIDERS;
Expand Down Expand Up @@ -59,8 +61,10 @@ RoundRobinLoadBalancerBuilder<ResolvedAddress, C> applyProviders(
* @param <ResolvedAddress> The resolved address type.
* @param <C> The type of connection.
* @return a new {@link RoundRobinLoadBalancerBuilder}.
* @deprecated use {#{@link LoadBalancers}} constructors instead.
*/
@SuppressWarnings("deprecation")
@Deprecated
public static <ResolvedAddress, C extends LoadBalancedConnection> RoundRobinLoadBalancerBuilder<ResolvedAddress, C>
builder(final String id) {
return applyProviders(id, new RoundRobinLoadBalancerFactory.Builder<>(id));
Expand Down
Loading