Explicitly declare transitive dependencies that we use directly #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Dependency-analysis plugin detected that some dependencies that we use directly not declared in our build configuration. Modifications: 1. This PR only adds missing dependencies. It does not remove anything. If you see a removed line, it only means I sorted existing dependencies in alphabetical order. 2. Adds `opentelemetry-instrumentation-bom` to `servicetalk-dependencies`. Result: Addresses "These transitive dependencies should be declared directly" warning from dependency-analysis plugin.
daschl
approved these changes
Jan 10, 2025
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jan 11, 2025
Motivation: Dependency-analysis plugin detected that some `api` dependencies are unused and can be either removed or downgraded to `implementation` / `testImplementation` scopes. Modifications: - Remove unused `api` dependencies. - Downgrade some to `implementation` / `testImplementation` scopes. - Regenerate lock files. Result: No more warnings from dependency-analysis plugin. Risk for users: Minimal. They can be broken only if they use some dependency at compile time without explicitly declaring it in their build, which is their mistake. Highlights: - Most changes are related to `servicetalk-*` dependencies, users likely have them anyway via other modules. - It's safe to remove `opentelemetry-api` from `opentelemetry-asynccontext` module because in apple#3164 we added `opentelemetry-context`. - Removal of `proto-google-common-protos` should not be an issue because it's already an `api` dependency for `grpc-api` module.
idelpivnitskiy
added a commit
that referenced
this pull request
Jan 13, 2025
Motivation: Dependency-analysis plugin detected that some `api` dependencies are unused and can be either removed or downgraded to `implementation` / `testImplementation` scopes. Modifications: - Remove unused `api` dependencies. - Downgrade some to `implementation` / `testImplementation` scopes. - Regenerate lock files. Result: No more warnings from dependency-analysis plugin. Risk for users: Minimal. They can be broken only if they use some dependency at compile time without explicitly declaring it in their build, which is their mistake. Highlights: - Most changes are related to `servicetalk-*` dependencies, users likely have them anyway via other modules. - It's safe to remove `opentelemetry-api` from `opentelemetry-asynccontext` module because in #3164 we added `opentelemetry-context`. - Removal of `proto-google-common-protos` should not be an issue because it's already an `api` dependency for `grpc-api` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Dependency-analysis plugin detected that some dependencies that we use directly not declared in our build configuration.
Modifications:
opentelemetry-instrumentation-bomtoservicetalk-dependencies.Result:
Addresses "These transitive dependencies should be declared directly" warning from dependency-analysis plugin.
Risk:
Because we only add missed dependencies, there is no risk of breaking existing users.