Update scope of test-fixtures dependencies #3166
Merged
+42
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Dependency-analysis plugin detected that some dependencies declared under incorrect scope. In this PR we only focus on test-dependencies. Modifications: - Update scope of dependencies as recommended by the plugin. Typically, it recommends to promote some `testFixturesImplementation` dependencies to `testFixturesApi`. - Add exclusion rule for `com.google.code.findbugs:jsr305` for `onIncorrectConfiguration` rule as we don't want to promote it explicitly, it's handled by `servicetalk-annotations`. - Exclude some false positives when plugin recommends to reduce scope, but `testFixturesApi` is actually required. Result: Addresses warning from dependency-analysis plugin that recommend different scope for test dependencies.
idelpivnitskiy
changed the title
mgodave
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Dependency-analysis plugin detected that some dependencies declared under incorrect scope. In this PR we only focus on test-fixtures dependencies.
Modifications:
testFixturesImplementationdependencies totestFixturesApi.com.google.code.findbugs:jsr305foronIncorrectConfigurationrule as we don't want to promote it explicitly, it's handled byservicetalk-annotations.testFixturesApiis actually required.Result:
Addresses warning from dependency-analysis plugin that recommends different scope for test dependencies.
Risk for users:
None, because changes were made only for test-fixures dependencies to expand their scope, not reduce.