scripts: fix release script #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When we upgraded gradle from 8.8 to 8.12 the JVM reporting format changed and that broke our release script in the part that ensures we're using the correct JVM to build docs. Modifications: - Fix the script
idelpivnitskiy
approved these changes
Jan 15, 2025
bryce-anderson
added a commit
that referenced
this pull request
Jan 15, 2025
Motivation: The release was run with a dirty main branch (which contained patch #3173) and those ended up being committed, but not with the line broken. That causes the release to fail on the checkstyleRoot task. Modifications: Revert the release commits so we can start over fresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we upgraded gradle from 8.8 to 8.12 the JVM reporting format changed and that broke our release script in the part that ensures we're using the correct JVM to build docs.
Modifications: