Fix the HappyEyeballsResolver and core Bootstraps under strict concurrency #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two changes are tied together: the HER severely affects the bootstraps setup logic.
|
Ok, I'm going to take the L on this extra allocation. I'm pretty sure this is the result of needing to no longer close over |
Lukasa
commented
Jan 22, 2025
| channelInitializer: channelInitializer, | ||
| channelOptions: channelOptions, | ||
| bindTarget: bindTarget | ||
| ) { |
There was a problem hiding this comment.
Specifically I think this is our new allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The HappyEyeballsResolver, being an old part of our stack, has a lot of code in it that fails to pass strict concurrency checking. That's deeply suboptimal.
Modifications:
Result:
Another step taken on the road to strict concurrency.