Add ChannelPipeline.SynchronousOperations.Position #3065
Conversation
|
@Lukasa I've updated the existing public APIs to use the new type to avoid confusing the compiler since the APIs are not usable in their current form. It you'd prefer all the existing APIs to be deprecated and add |
|
Thanks Tim. Yeah, can we use overloads and |
|
Updated - I was getting compiler errors due to "ambiguous references..." without the disfavoured overloads so added them in |
| @@ -175,11 +175,12 @@ public final class ChannelPipeline: ChannelInvoker { | |||
| ) -> EventLoopFuture<Void> { | |||
| let future: EventLoopFuture<Void> | |||
|
|
|||
| let syncPosition = ChannelPipeline.SynchronousOperations.Position(position) | |||
There was a problem hiding this comment.
This conversion isn't right: we can't create the synchronous position object until we're on the loop.
| extension ChannelPipeline.SynchronousOperations { | ||
| /// A `Position` within the `ChannelPipeline`'s `SynchronousOperations` used to insert non-sendable handlers | ||
| /// into the `ChannelPipeline` at a certain position. | ||
| @preconcurrency |
There was a problem hiding this comment.
No need for a preconcurrency annotation here, we should get this right the first time.
| /// A `Position` within the `ChannelPipeline`'s `SynchronousOperations` used to insert non-sendable handlers | ||
| /// into the `ChannelPipeline` at a certain position. | ||
| @preconcurrency | ||
| public enum Position { |
There was a problem hiding this comment.
Let's mark this type explicitly non-Sendable
| /// After the given `ChannelHandler`. | ||
| case after(ChannelHandler) | ||
|
|
||
| package init(_ position: ChannelPipeline.Position) { |
There was a problem hiding this comment.
I can't really see any reason to not make this public: we may need this conversion logic in other places.
| @@ -83,10 +83,11 @@ extension ChannelPipeline { | |||
| ) -> EventLoopFuture<Void> { | |||
| let future: EventLoopFuture<Void> | |||
|
|
|||
| let syncPosition = ChannelPipeline.SynchronousOperations.Position(position) | |||
There was a problem hiding this comment.
This should only be created on the EL.
| @@ -126,10 +127,11 @@ extension ChannelPipeline { | |||
| ) -> EventLoopFuture<Void> { | |||
| let future: EventLoopFuture<Void> | |||
|
|
|||
| let syncPosition = ChannelPipeline.SynchronousOperations.Position(position) | |||
There was a problem hiding this comment.
This should only be created on the EL.
| @@ -173,10 +175,11 @@ extension ChannelPipeline { | |||
| ) -> EventLoopFuture<Void> { | |||
| let future: EventLoopFuture<Void> | |||
|
|
|||
| let syncPosition = ChannelPipeline.SynchronousOperations.Position(position) | |||
There was a problem hiding this comment.
This should only be created on the EL.
| @@ -342,10 +345,11 @@ extension ChannelPipeline { | |||
| ) -> EventLoopFuture<Void> { | |||
| let future: EventLoopFuture<Void> | |||
|
|
|||
| let syncPosition = ChannelPipeline.SynchronousOperations.Position(position) | |||
There was a problem hiding this comment.
This should only be created on the EL.
Adds a new
ChannelPipeline.SynchronousOperations.Positiontype to fill a hole in the API that prevented non-sendable Channel handlers being added at a position to the pipeline via the synchronous operations.