byte-buffer: use malloc_good_size on Darwin to allocate memory
#3066
Conversation
Motivation: With this change, on Darwin, ByteBuffer will use less memory, and memory allocations will be aligned with pages better, hopefully improving memory efficiency. Modifications: - Introduces a new internal helper method to `_Storage` that returns the optimal storage size - Uses that to malloc capacity.
|
|
||
| @testable import NIOCore | ||
|
|
||
| #if canImport(Darwin) |
There was a problem hiding this comment.
Let's make these tests cross-platform by redefining the logic here. We can just have an abstraction function that is essentially equivalent to mallocSize, but allows us to validate that that's what we're actually using.
There was a problem hiding this comment.
@Lukasa apologies for the delay — I think this gets it to a good spot. Once that gets in, I'll get a bit more experience around ByteBuffer and then see if it's useful to figure out better Linux allocation strategies.
| func testZeroCapacity() { | ||
| let allocator = ByteBufferAllocator() | ||
| let buffer = allocator.buffer(capacity: 0) | ||
| XCTAssertEqual(buffer.capacity, 0) |
There was a problem hiding this comment.
Why are we asking for capacity differently here than in the rest of the tests?
There was a problem hiding this comment.
Same approach as the rest of the tests would be fine, BUT zero being explicit feels nice.
There was a problem hiding this comment.
I think it might be nice to keep the tests discussing capacity the same way.
Motivation:
With this change, on Darwin, ByteBuffer will use less memory, and memory allocations will be aligned with pages better, hopefully improving memory efficiency.
This is part 1 of #2770. The next step is to figure out better allocation strategy for Libc, Musl, etc.
Modifications:
_Storagethat returns the optimal storage size