-
Notifications
You must be signed in to change notification settings - Fork 126
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove redundant Equatable conformances in code generation (#214)
### Motivation Fixes #210. ### Modifications With this PR. we are removing the explicit `Equatable` conformance when a type already conforms to `Hashable` in generated code. ### Result Generated types now conforms explicitly to `Hashable` but not to `Equatable`. ```diff - public struct Generated: Equatable, Hashable { } + public sutrct Generated: Hashable { } ``` ### Test Plan I have updated the reference ressources used by tests to check generated code.
- Loading branch information
Showing
7 changed files
with
292 additions
and
301 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
235 changes: 117 additions & 118 deletions
235
Tests/OpenAPIGeneratorReferenceTests/Resources/ReferenceSources/Petstore/Types.swift
Large diffs are not rendered by default.
Oops, something went wrong.
233 changes: 116 additions & 117 deletions
233
...torReferenceTests/Resources/ReferenceSources/Petstore_FF_MultipleContentTypes/Types.swift
Large diffs are not rendered by default.
Oops, something went wrong.
112 changes: 56 additions & 56 deletions
112
Tests/OpenAPIGeneratorReferenceTests/SnippetBasedReferenceTests.swift
Large diffs are not rendered by default.
Oops, something went wrong.