Fall back to email if name is empty #1606
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-01-10 03:39:17 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-01-10 03:39:13 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-01-10 03:39:18 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-01-10 03:39:14 CET |
ChiragAgg5k
reviewed
Jan 10, 2025
| @@ -28,7 +28,7 @@ | |||
| const getMemberships = async (teamId: string) => { | |||
| const memberships = await sdk.forConsole.teams.listMemberships(teamId); | |||
| return memberships.memberships.map((team) => team.userName); | |||
| return memberships.memberships.map((team) => team.userName || team.userEmail); | |||
There was a problem hiding this comment.
would also need to do the same in settings page here -
ChiragAgg5k
reviewed
Jan 10, 2025
| @@ -58,7 +58,7 @@ | |||
| } else newOrgModal.set(true); | |||
| } | |||
| $: avatars = $members.memberships?.map((m) => m.userName) ?? []; | |||
| $: avatars = $members.memberships?.map((m) => m.userName || m.userEmail) ?? []; | |||
There was a problem hiding this comment.
maybe we should also update it to team.userName instead of just m? this looks pretty inconsistent
There was a problem hiding this comment.
It's m for membership, not team
The fetch avatar API won't render properly if an empty string is provided for the name so we should fall back to the email if the name is empty.
stnguyen90
force-pushed
the
fix-1598-fix-console-avatar
branch
from
bd22abf to
f8712c3
Compare
ChiragAgg5k
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The fetch avatar API won't render properly if an empty string is provided for the name so we should fall back to the email if the name is empty.
Fixes #1598
Test Plan
Manually tested before:
After:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes