Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed navbar at top and add hamburger menu for mobile screen #1236

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

Utsavladia
Copy link
Contributor

Title and Issue number

Fixed navbar at top and added hamburger menu #1221

Title :

Issue No. : #1221

Code Stack :

Close #1221

Video (mandatory)

image
image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have gone through the contributing.md file before contributing

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a GSSOC'24 contributor
  • I'm a SSOC'24 contributor

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit 4b8da36
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/66b7688b22e08c0008ec7551
😎 Deploy Preview https://deploy-preview-1236--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Utsavladia
Copy link
Contributor Author

@apu52
Kindly review this one so I can merge conflicts

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Utsavladia this PR has some merge conflicts. Please try to resolve the conflicts ASAP so that I can review the code & be able to merge it.

@Utsavladia
Copy link
Contributor Author

@apu52
Resolved ✅

@Utsavladia
Copy link
Contributor Author

@apu52
Kindly mrege this PR before GSSOC ends 😌

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Utsavladia the navbar is not looking good in your PR , it's moving along the scrolling . Please try to resolve it ASAP.& also in the responsive section I can't access the navabar...Please also check it.

@Utsavladia
Copy link
Contributor Author

@apu52
fixed the navbar at top

image

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Utsavladia good work

@apu52 apu52 merged commit e7b744a into apu52:main Aug 10, 2024
4 checks passed
@apu52 apu52 added bug Something isn't working gssoc level1 and removed changesrequested labels Aug 10, 2024
@Utsavladia
Copy link
Contributor Author

Utsavladia commented Aug 10, 2024

@apu52 There is some large issue with the light theme for navbar I will have analyse it and it will take time
meanwhile thankyou for merging before time
I will fix it if you want in the new issue..
kindly reply me if you want me to fix this issue and make the website better..

@apu52
Copy link
Owner

apu52 commented Sep 8, 2024

@apu52 There is some large issue with the light theme for navbar I will have analyse it and it will take time meanwhile thankyou for merging before time I will fix it if you want in the new issue.. kindly reply me if you want me to fix this issue and make the website better..

yeah . u can fix it . Now the website is also not working. U can try to raise new issue pointing this .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Navbar at top and make it responsive
2 participants