fix(PE-7163): update validate utils #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atticusofsparta
force-pushed
the
PE-7163-update-validate-utils
branch
2 times, most recently
from
529de2f to
1ca90e8
Compare
atticusofsparta
force-pushed
the
PE-7163-update-validate-utils
branch
from
1ca90e8 to
58f069f
Compare
atticusofsparta
changed the base branch from
develop
to
PE-6910-primary-names
atticusofsparta
force-pushed
the
PE-7163-update-validate-utils
branch
2 times, most recently
from
b1f0403 to
0da9dc4
Compare
atticusofsparta
force-pushed
the
PE-7163-update-validate-utils
branch
from
0da9dc4 to
1c52613
Compare
atticusofsparta
changed the base branch from
PE-6910-primary-names
to
develop
fedellen
reviewed
Dec 4, 2024
fedellen
reviewed
Dec 4, 2024
fedellen
reviewed
Dec 4, 2024
fedellen
reviewed
Dec 4, 2024
| for _, tName in ipairs(knownAddressTags) do | ||
| -- Format all incoming addresses | ||
| msg.Tags[tName] = msg.Tags[tName] and utils.formatAddress(msg.Tags[tName]) or nil | ||
| -- aos assigns tag values to the base message level as well |
There was a problem hiding this comment.
interesting. so theres not really any need to explicitly reach into Tags object?
fedellen
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.