Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ID fix for concatenation #70

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Release ID fix for concatenation #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cbae32
fix(msg): remove concant msg id
atticusofsparta Jan 28, 2025
75a3ed7
Merge pull request #69 from ar-io/PE-7534-remove-msg-id
atticusofsparta Jan 29, 2025
b0ac272
fix(changelog): add fixes to changelog
atticusofsparta Jan 29, 2025
59b4298
Merge pull request #71 from ar-io/PE-7534-remove-msg-id
atticusofsparta Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Fixed

- Removed print with ID in Handler wrapper since ID can be null on dry runs.

## [12] - [mwCMAjglwV_96oEMEIi5epg_QXElOMzEcLkCUeQyGGo] - (2025-1-28)

### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/common/utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ function utils.createHandler(tagName, tagValue, handler, position)
end

-- sometimes the message id is not present on dryrun so we add a stub string to prevent issues with concat string
print("Handling Action [" .. msg.Id or "no-msg-id" .. "]: " .. tagValue)

local prevOwner = tostring(Owner)
local prevControllers = utils.deepCopy(Controllers)
assert(prevControllers, "Unable to deep copy controllers")
Expand Down
Loading