PE-7517: quick wins v1.8.0 #140
Merged
+79
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kunstmusik
commented
Jan 28, 2025
kunstmusik
commented
- Add Delegate EAY column to Active Stakes table
- Add copy button in tables where Domain Name is shown that copies the domain name (without “https://")
kunstmusik
changed the base branch from
develop
to
PE-7497-add-settings-modal-for-setting-devnet-testnet-and-cu-url
|
Visit the preview URL for this PR (updated for commit a89f33f): https://ar-io-network-portal-a40ee--pr140-pe-7517-quick-wins-v-o3gvybex.web.app (expires Tue, 11 Feb 2025 17:24:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7abfae09c4446982a71cbb94b0cbf4688377a111 |
| @@ -125,7 +141,7 @@ const MyStakesTable = () => { | |||
|
|
|||
| setActiveStakes(activeStakes); | |||
| setPendingWithdrawals(pendingWithdrawals); | |||
| }, [delegateStakes, gateways, isFetching]); | |||
| }, [delegateStakes, gateways, isFetching, protocolBalance]); | |||
There was a problem hiding this comment.
this feels like its worth a useQuery hook with the dependencies as keys
There was a problem hiding this comment.
I think it's alright here as it's not going to be re-used elsewhere. Perhaps there's an opportunity to further optimize but for now I think it's okay to keep this as-is.
atticusofsparta
approved these changes
Jan 28, 2025
Base automatically changed from
PE-7497-add-settings-modal-for-setting-devnet-testnet-and-cu-url
to
develop
January 28, 2025 19:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.