E2E pluginUpgrader tests ready

aragon · Jan 4, 2024 · 28402b5 · 28402b5
1 parent d325aab
commit 28402b5
Show file tree

Hide file tree

Showing 3 changed files with 320 additions and 18 deletions.
diff --git a/packages/contracts/src/SpacePluginSetup.sol b/packages/contracts/src/SpacePluginSetup.sol
@@ -79,7 +79,7 @@ contract SpacePluginSetup is PluginSetup {
                     _targetPluginAddresses
                 );
             permissions[2] = PermissionLib.MultiTargetPermission({
-                operation: PermissionLib.Operation.Grant,
+                operation: PermissionLib.Operation.GrantWithCondition,
                 where: _dao,
                 who: _pluginUpgrader,
                 condition: address(_onlyPluginUpgraderCondition),

diff --git a/packages/contracts/test/integration-testing/governance-plugins-setup.ts b/packages/contracts/test/integration-testing/governance-plugins-setup.ts
@@ -14,10 +14,7 @@ import {
   UpgradedEvent,
 } from '../../typechain/@aragon/osx/core/dao/DAO';
 import {PluginSetupRefStruct} from '../../typechain/@aragon/osx/framework/dao/DAOFactory';
-import {
-  UpdateAppliedEvent,
-  UpdatePreparedEvent,
-} from '../../typechain/@aragon/osx/framework/plugin/setup/PluginSetupProcessor';
+import {UpdatePreparedEvent} from '../../typechain/@aragon/osx/framework/plugin/setup/PluginSetupProcessor';
 import {
   findEvent,
   findEventTopicLog,