Skip to content

Commit

Permalink
WIP testing
Browse files Browse the repository at this point in the history
  • Loading branch information
brickpop committed Jan 30, 2024
1 parent b0ec215 commit bb6dab0
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@
"internalType": "uint64",
"name": "duration",
"type": "uint64"
},
{
"internalType": "uint256",
"name": "minProposerVotingPower",
"type": "uint256"
}
],
"internalType": "struct MajorityVotingBase.VotingSettings",
Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/test/integration-testing/deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe('PluginRepo Deployment', function () {

case GovernancePluginsSetupParams.PLUGIN_SETUP_CONTRACT_NAME:
expect(receivedStriMetadata).to.equal(
'ipfs://QmNh5KHv167RKZgD8zb6d3CvRE7mNT8AZYZkwrmvyRt1YD'
'ipfs://QmUivtg6CD3XUvArRS1BqaPYUrKU7oyw8MU59oemL3zxLQ'
);
break;

Expand Down
2 changes: 0 additions & 2 deletions packages/contracts/test/unit-testing/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,11 @@ export type VotingSettings = {
supportThreshold: BigNumber;
minParticipation: BigNumber;
duration: number;
minProposerVotingPower: number;
};

export const defaultMainVotingSettings: VotingSettings = {
duration: 60 * 60, // 1 second
minParticipation: pctToRatio(30), // 30%
supportThreshold: pctToRatio(50), // 50% + 1
minProposerVotingPower: 0,
votingMode: VotingMode.EarlyExecution,
};
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('Governance Plugins Setup', function () {
it('returns the plugin, helpers, and permissions (no pluginUpgrader)', async () => {
const pluginUpgrader = ADDRESS_ZERO;

// Params: (MajorityVotingBase.VotingSettings, address, address)
// Params: (MajorityVotingBase.VotingSettings, address[], uint64, address)
const initData = abiCoder.encode(
getNamedTypesFromMetadata(
buildMetadata.pluginSetup.prepareInstallation.inputs
Expand All @@ -58,7 +58,6 @@ describe('Governance Plugins Setup', function () {
supportThreshold: pctToRatio(25),
minParticipation: pctToRatio(50),
duration: 60 * 60 * 24 * 5,
minProposerVotingPower: 0,
},
[alice.address],
60 * 60 * 24,
Expand Down Expand Up @@ -159,7 +158,6 @@ describe('Governance Plugins Setup', function () {
supportThreshold: pctToRatio(25),
minParticipation: pctToRatio(50),
duration: 60 * 60 * 24 * 5,
minProposerVotingPower: 0,
},
[alice.address],
60 * 60 * 24,
Expand Down

0 comments on commit bb6dab0

Please sign in to comment.