Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal review #4

Merged
merged 29 commits into from
Jan 24, 2024
Merged

Internal review #4

merged 29 commits into from
Jan 24, 2024

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Nov 17, 2023

Changes implemented:

  • Replacing the pluginUpdater usage:
    • Make strict use of execute to perform grant, applyUpdate and revoke with the intended values
    • Drop UPDATE_PLUGIN_PERMISSION requests
  • Adding OnlyPluginUpdaterCondition to restrict the above
  • Updating GovernancePluginsSetup and SpacePluginSetup constructors to receive the PSP address
    • Used when deploying the pluginUpdater condition
  • Adapting the MemberAccessExecuteCondition to only allow execute calls rather than expecting direct actions
  • Update the relevant tests and add new ones

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ brickpop
❌ Jør∂¡


Jør∂¡ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brickpop brickpop merged commit 195fd4a into main Jan 24, 2024
4 of 5 checks passed
@brickpop brickpop deleted the f/internal-review branch January 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants