Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional improvements #5

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Additional improvements #5

merged 14 commits into from
Feb 8, 2024

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Jan 31, 2024 •
edited
Loading

The following PR addresses internal recommendations:

  • Simplify the membership definition by moving it to the MainVotingPlugin
    • Updating the actions generated by proposeNewMember and proposeRemoveMember
    • Updating the MemberAccessExecuteCondition contract accordingly
  • Renamed minDuration into duration (VotingSettings, MainVotingPlugin)
  • Removed the unused minProposerVotingPower (VotingSettings, MainVotingPlugin)
  • Grouped related contracts into folders
  • Renamed:
    • addAddresses() => addEditor()
    • removeAddresses() => removeEditor()
  • Added addMember() and removeMember() (MainVotingPlugin)
  • Removed unused parameters from createProposal() (MainVotingPlugin)
  • Removed disabled addAddresses() and removeAddresses() (MemberAccessPlugin)
  • Removed an unused parameter from approve() (MemberAccessPlugin)
  • Forked and adapted contracts from Aragon:
    • Addresslist
    • IEditors
    • IMembers
    • IMultisig
    • MajorityVotingBase

carlosgj94
carlosgj94 requested changes Feb 6, 2024
View reviewed changes
packages/contracts/src/conditions/MemberAccessExecuteCondition.sol Outdated Show resolved Hide resolved
packages/contracts/src/conditions/MemberAccessExecuteCondition.sol Show resolved Hide resolved
packages/contracts/src/governance/MainVotingPlugin.sol Outdated Show resolved Hide resolved
packages/contracts/src/governance/base/IEditors.sol Outdated Show resolved Hide resolved
packages/contracts/src/governance/base/Addresslist.sol Outdated Show resolved Hide resolved
packages/contracts/src/governance/base/IMembers.sol Outdated Show resolved Hide resolved
packages/contracts/src/governance/base/IMultisig.sol Outdated Show resolved Hide resolved
packages/contracts/src/governance/base/MajorityVotingBase.sol Outdated Show resolved Hide resolved
@brickpop brickpop merged commit e3c8994 into main Feb 8, 2024
5 checks passed
@brickpop brickpop deleted the f/internal-audit-extra-suggestions branch February 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgj94 carlosgj94 carlosgj94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brickpop @carlosgj94