fix: tests now working, changing the createProposal to payable and re…

…alistic mocks

script/OptimisticTokenVotingPlugin.s.sol

@@ -47,7 +47,7 @@ contract OptimisticTokenVotingPluginScript is Script {
         // 2. // 2. Publishing it in the Aragon OSx Protocol
         PluginRepo pluginRepo = PluginRepoFactory(pluginRepoFactory)
             .createPluginRepoWithFirstVersion(
-                "optimistic-crosschain69",
+                "optimistic-crosschain72",
                 address(pluginSetup),
                 msg.sender,
                 "0x00", // TODO: Give these actual values on prod
@@ -58,7 +58,7 @@ contract OptimisticTokenVotingPluginScript is Script {
         DAOFactory.DAOSettings memory daoSettings = DAOFactory.DAOSettings(
             address(0),
             "",
-            "optimistic-crosschain69", // This should be changed on each deployment
+            "optimistic-crosschain72", // This should be changed on each deployment
             ""
         );
 

src/IOptimisticTokenVoting.sol

@@ -27,7 +27,7 @@ interface IOptimisticTokenVoting {
         uint256 _allowFailureMap,
         uint64 _startDate,
         uint64 _endDate
-    ) external returns (uint256 proposalId);
+    ) external payable returns (uint256 proposalId);
 
     /// @notice Checks if an account can participate on an optimistic proposal. This can be because the proposal
     /// - has not started,

src/L2VetoAggregation.sol

@@ -62,10 +62,7 @@ contract L2VetoAggregation is NonblockingLzApp {
         bytes memory remoteAddresses = abi.encodePacked(
             _bridgeSettings.l1Plugin
         );
-        setTrustedRemoteAddress(
-            _bridgeSettings.chainId,
-            remoteAddresses
-        );
+        setTrustedRemoteAddress(_bridgeSettings.chainId, remoteAddresses);
     }
 
     // This function is called when data is received. It overrides the equivalent function in the parent contract.

src/OptimisticTokenVotingPlugin.sol

@@ -187,12 +187,10 @@ contract OptimisticTokenVotingPlugin is
 
         __LzApp_init(bridgeSettings.bridge);
         bytes memory remoteAddresses = abi.encodePacked(
-            _bridgeSettings.l2VotingAggregator
-        );
-        setTrustedRemoteAddress(
-            _bridgeSettings.chainId,
-            remoteAddresses
+            _bridgeSettings.l2VotingAggregator,
+            address(this)
         );
+        setTrustedRemote(_bridgeSettings.chainId, remoteAddresses);
 
         emit MembershipContractAnnounced({definingContract: address(_token)});
     }
@@ -338,7 +336,12 @@ contract OptimisticTokenVotingPlugin is
         uint256 _allowFailureMap,
         uint64 _startDate,
         uint64 _endDate
-    ) external auth(PROPOSER_PERMISSION_ID) returns (uint256 proposalId) {
+    )
+        external
+        payable
+        auth(PROPOSER_PERMISSION_ID)
+        returns (uint256 proposalId)
+    {
         // Check that either `_msgSender` owns enough tokens or has enough voting power from being a delegatee.
         {
             uint256 minProposerVotingPower_ = governanceSettings

src/lzApp/LzApp.sol

@@ -181,8 +181,8 @@ abstract contract LzApp is
     // this function set the trusted path for the cross-chain communication
     function setTrustedRemote(
         uint16 _remoteChainId,
-        bytes calldata _path
-    ) external onlyOwner {
+        bytes memory _path
+    ) internal {
         trustedRemoteLookup[_remoteChainId] = _path;
         emit SetTrustedRemote(_remoteChainId, _path);
     }