Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard proposal creation #12

Merged
merged 14 commits into from
May 6, 2024
Merged

Standard proposal creation #12

merged 14 commits into from
May 6, 2024

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Apr 22, 2024 •
edited
Loading

  • Adding Multisig and EmergencyMultisig
    • EmergencyMultisig is not customized yet
  • Add their respective plugin setup's
  • Apply the required customizations for Taiko
  • Porting and adapting the test suite for multisig plugin
  • Adapt the deployment script as well

@brickpop brickpop requested a review from carlosgj94 April 26, 2024 13:46
carlosgj94
carlosgj94 requested changes May 3, 2024
View reviewed changes
src/common.sol Outdated Show resolved Hide resolved
src/Multisig.sol Show resolved Hide resolved
src/metadata/multisig-build-metadata.json Outdated Show resolved Hide resolved
test/common.sol Outdated Show resolved Hide resolved
@brickpop brickpop self-assigned this May 6, 2024
@carlosgj94 carlosgj94 self-requested a review May 6, 2024 12:54
carlosgj94
carlosgj94 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@carlosgj94 carlosgj94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtml

@brickpop brickpop merged commit e28e3fc into main May 6, 2024
2 checks passed
@brickpop brickpop deleted the f/std-proposal-creation branch May 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgj94 carlosgj94 carlosgj94 approved these changes

Assignees

@brickpop brickpop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brickpop @carlosgj94