Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some HTTP error handling #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some HTTP error handling #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions org-sync-gitlab.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,20 @@
(defun org-sync-gitlab-request (method url &optional data extra-headers)
"Sends HTTP request at URL using METHOD with DATA
Return a JSON response"
;; TODO implement error handling - we have to check we get 200 OK back from
;; server before trying to parse
(let* ((url-request-method method)
(url-request-data data)
(url-request-extra-headers (append `(("Private-Token" . ,(org-sync-gitlab-get-auth-token)))
extra-headers))
)
(message "%s %s %s" method url (prin1-to-string data))
;; first line is like 'HTTP/1.1 200 OK' so we move forward to capture the
;; status code and make sure it is 200
(with-current-buffer (url-retrieve-synchronously url)
(beginning-of-buffer)
(search-forward " ")
(setq http-code (thing-at-point 'word 'no-properties))
(if (not (string-equal http-code "200"))
(error "Didn't get 200 OK for HTTP request"))
(goto-char url-http-end-of-headers)
(prog1
(if
Expand Down