Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gitlab subgroups #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gjnoonan
Copy link

@gjnoonan gjnoonan commented Dec 8, 2018

This commit updates org-sync-gitlab-backend to allow it to properly parse urls
with multiple subgroups. I've replaced the regex that was used, to now use the
url-parse functions that come with emacs.

This commit updates `org-sync-gitlab-backend` to allow it to properly
parse urls with multiple subgroups. I've replaced the regex that was
used, to now use the `url-parse` functions that come with emacs.
@divansantana
Copy link

@gjnoonan @plajjan Can confirm this bug and confirm the fix works with latest gitlab.

@plajjan
Copy link
Collaborator

plajjan commented Dec 18, 2018

Can you add some example URLs that show what a URL with subgroups might look like? I imagine it will be easier for the next person coming around, wondering what this function does, to see some example inputs. A proper test case would of course be best but seeing how we have a long way to go there (there are like no tests now) I think adding a comment above the function with a few examples is the second best thing.

@divansantana
Copy link

@plajjan sure! The git ssh address I'm using is: [email protected]:digital/ops/test.git

So in this case the digital is the first group, ops is the second and test is the project name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants