Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR master <--- 274 pydata theme #302

Merged
merged 10 commits into from
Jan 30, 2023
Merged

PR master <--- 274 pydata theme #302

merged 10 commits into from
Jan 30, 2023

Conversation

ekansa
Copy link
Collaborator

@ekansa ekansa commented Jan 30, 2023

brief description of changes

The new pydata theme looks great and has an easier to maintain and better organization

issues addressed

This addresses issue #274: #274

further comments

This PR is done in the context of training Eric Kansa to be a maintainer of the arches-doc repo


This box must be checked

  • [ x] the PR branch was originally made from the base branch

This box should be checked

  • [x ] after these changes the docs build locally without error

This box should only be checked you intend to follow through on it (we can do it on our end too)

  • I will cherry-pick all commits in this PR into other branches that should have them after this PR is merged

@mradamcox mradamcox self-requested a review January 30, 2023 22:12
Copy link
Member

@mradamcox mradamcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds locally and looks good to me. I think there are still some structural improvements we can make, but it'll be good to have this merged into master for now.

@ekansa ekansa merged commit d274f9f into master Jan 30, 2023
@mradamcox mradamcox deleted the 274_pydata_theme branch January 30, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants