Changes to allow for a single form per tile #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongundel
force-pushed
the
adg/154-single-tile-forms
branch
from
0d8dc76 to
0175346
Compare
chrabyrd
reviewed
Dec 30, 2024
| @@ -26,32 +26,19 @@ defineProps<{ | |||
| mode?: DataComponentMode; | |||
| }>(); | |||
|
|
|||
| defineEmits([OPEN_EDITOR]); | |||
| const emit = defineEmits([OPEN_EDITOR, "updated"]); | |||
There was a problem hiding this comment.
nit: emits to match the rest of the app
| ), | ||
| }); | ||
| } | ||
| await updateSchemeNamespace( |
There was a problem hiding this comment.
unintentional. looks like some kind of merge issue. Thanks for the catch.
| schemeComponents.find((component) => { | ||
| return component.id === newValue.activeTab; | ||
| }) || schemeComponents[0]; | ||
| console.log(currentEditor.value); |
| currentEditor.value = | ||
| schemeComponents.find((component) => { | ||
| return component.id === newValue.activeTab; | ||
| }) || schemeComponents[0]; |
There was a problem hiding this comment.
could this fallback end up being confusing for the user?
There was a problem hiding this comment.
yeah, actually was made for tabs. Now that tabs are gone, it should be also.
chrabyrd
reviewed
Jan 2, 2025
arches_lingo/src/arches_lingo/components/scheme/report/SchemeNamespace.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeNamespace.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/editor/SchemeEditor.vue
Outdated
Show resolved
Hide resolved
chrabyrd
reviewed
Jan 2, 2025
| @@ -86,7 +86,7 @@ const getRef = (el: object | null, index: number) => { | |||
| <SchemeEditor | |||
| v-if="editorTab" | |||
| :editor-max="sectionVisible" | |||
| :active-tab="editorTab" | |||
| :editor-form="editorTab" | |||
There was a problem hiding this comment.
still using tab language here?
chrabyrd
reviewed
Jan 2, 2025
| @@ -34,7 +34,7 @@ const onClose = () => { | |||
| }; | |||
|
|
|||
| const onOpenEditor = (tab: string, tileId: string) => { | |||
| editorTab.value = tab; | |||
| editorForm.value = tab; | |||
There was a problem hiding this comment.
tab language here too. Sorry to be nitpicky but this is the ticket that purges the concept of tabs from the frontend yeah?
There was a problem hiding this comment.
Yeap. Thanks for finding those. 🏓
|
let the collapsing begin. |
aarongundel
added a commit
that referenced
this pull request
Jan 2, 2025
* Changes to allow for a single form per tile * move section types to prep for conflict * PR feedback * pr feedback * purge tab * purge more tabs
aarongundel
added a commit
that referenced
this pull request
Jan 2, 2025
aarongundel
added a commit
that referenced
this pull request
Jan 2, 2025
aarongundel
added a commit
that referenced
this pull request
Jan 3, 2025
aarongundel
added a commit
that referenced
this pull request
Jan 3, 2025
* Changes to allow for a single form per tile * move section types to prep for conflict * PR feedback * pr feedback * purge tab * purge more tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a single editor per tile, removes tabbed interface.