adds notes section #162
adds notes section #162
Conversation
arches_lingo/src/arches_lingo/components/scheme/report/SchemeNote.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeNote.vue
Outdated
Show resolved
Hide resolved
| /> | ||
| </div> | ||
| <div> | ||
| {{ $gettext("Contributors") }}: |
There was a problem hiding this comment.
one small thing I missed first pass, mind wrapping these interpolations in a span or div or something? Prevents "naked" strings in the HTML
| </template> | ||
| <template #drawer="{ rowData }"> | ||
| <div> | ||
| <span>{{ $gettext("Bibliographic Sources") }}:</span> |
There was a problem hiding this comment.
had to look up i18n patterns for this: TIL -- the colon should go inside the gettext call.
There was a problem hiding this comment.
good to know, guess it makes sense from an RTL text perspective.
| /> | ||
| </div> | ||
| <div> | ||
| <span>{{ $gettext("Contributors") }}:</span> |
| @delete-string="deleteSectionValue" | ||
| > | ||
| <template #name="{ rowData }"> | ||
| {{ (rowData as SchemeStatement).statement_content_n1 }} |
There was a problem hiding this comment.
I'm unsure, but I think this needs span wrapping as well
There was a problem hiding this comment.
no objections. 🏓
| <span>{{ | ||
| (rowData as SchemeStatement).statement_content_n1 | ||
| }}</span> |
There was a problem hiding this comment.
lol bad formatting but I wont block 😉
There was a problem hiding this comment.
That was actually automatic from the pre-commit hook, I didn't do that.
There was a problem hiding this comment.
I figured that was the case 😁
aarongundel
merged commit 0868230
into
adg/146-genericize-label-viewer
* adds notes section * fix naming nit * wrap gettext in spans * pr feedback * pr feedback
Adds notes section with generic metastring viewer.