-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement scheme creation #157 #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Dec 30, 2024
arches_lingo/src/arches_lingo/components/scheme/report/SchemeNamespace.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Show resolved
Hide resolved
chrabyrd
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall 👍
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeNamespace.vue
Outdated
Show resolved
Hide resolved
jacobtylerwalls
force-pushed
the
jtw/new-scheme-button
branch
2 times, most recently
from
January 2, 2025 17:45
190f8f5
to
b6925b2
Compare
aarongundel
reviewed
Jan 2, 2025
Base automatically changed from
adg/154-single-tile-forms
to
adg/146-scheme-names
January 2, 2025 20:06
jacobtylerwalls
force-pushed
the
jtw/new-scheme-button
branch
2 times, most recently
from
January 2, 2025 22:00
85ed572
to
b6be774
Compare
aarongundel
force-pushed
the
adg/146-scheme-names
branch
from
January 2, 2025 22:30
eb4d590
to
21057da
Compare
jacobtylerwalls
force-pushed
the
jtw/new-scheme-button
branch
from
January 2, 2025 22:36
b6be774
to
c2328b5
Compare
aarongundel
force-pushed
the
adg/146-scheme-names
branch
from
January 3, 2025 17:16
3f68847
to
fa5dc08
Compare
jacobtylerwalls
force-pushed
the
jtw/new-scheme-button
branch
from
January 3, 2025 17:32
c2328b5
to
c07c6d1
Compare
chrabyrd
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: pull the latest from the jtw/pythonic-resource-models branch