151 scheme rights form #180
Open
+578
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@njkim when able, could you rebase this? Looks like there's a lot of leakage from Johnathan's work. |
njkim
force-pushed
the
151_scheme_rights_form
branch
from
b889521 to
79a9a92
Compare
chrabyrd
requested changes
Jan 22, 2025
Comment on lines
37
to
44
| export const LANGUAGE_CONTROLLED_LIST = "55ce793b-a51a-4b25-811d-d08ea797f8c3"; | ||
| export const LABEL_CONTROLLED_LIST = "deb847fc-f4c3-4e82-be19-04641579f129"; | ||
| export const STATUSES_CONTROLLED_LIST = "2cc0e054-ef9b-41ae-8e86-e0c3b4e7ca00"; | ||
| export const METATYPES_CONTROLLED_LIST = "ef69e772-de53-45fe-98d4-bf3e7b10eb57"; | ||
| export const EVENT_TYPES_CONTROLLED_LIST = | ||
| "6eaa2c6f-af83-464c-9200-051c4cfe7e8e"; | ||
| export const RIGHT_TYPE_CONTROLLED_LIST = "1c950e16-3fcf-4f33-9e5e-ce5c6c992cca"; | ||
| export const NOTE_CONTROLLED_LIST = "aba2a0b4-75a4-45ba-8b57-021f3ca92a6a"; |
There was a problem hiding this comment.
we're trying to avoid hardcoding UUIDs on the frontend. Are you able to use a different pattern for this?
| } | ||
| } | ||
|
|
||
| async function getSectionValue() { |
There was a problem hiding this comment.
can this be refactored or split into multiple fucntions?
| todo | ||
| </SchemeReportSection> | ||
| <div> | ||
| <div v-if="!mode || mode === VIEW"> |
There was a problem hiding this comment.
Is there a reason this section is divided by mode? Shouldn't it just be an arg fed into sub components, or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.