Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dotfiles in webpack file discovery #11094 #11203

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jacobtylerwalls
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Before 7.5.3, the webpack config special-cased a specific common dotfile created on mac systems (.DS_Store) that results from moving files using the Finder. Without that special case, node throws a TypeError (see issue). That special case was removed in bc0d79c.

Now, the special case is restored, but generalized to any dotfile, e.g. .gitkeep (example).

Issues Solved

Closes #11094

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Ticket Background

  • Sponsored by: Getty Conservation Institute
  • Found by: @jacobtylerwalls
  • Tested by: @
  • Designed by: @

Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@jacobtylerwalls jacobtylerwalls merged commit 37cd4c3 into dev/7.5.x Jul 18, 2024
2 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/harden-webpack-dotfiles branch July 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presence of .DS_Store dotfiles (Mac) in arches/app/media/js breaks webpack build
2 participants