forked from FabricMC/fabric-loom
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Legacy Forge versions for loom 1.2 #138
Draft
Jab125
wants to merge
15
commits into
architectury:dev/1.2
Choose a base branch
from
Jab125:dev/1.2
base: dev/1.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d34da66
working on 1.12.2, not sure about anything else
Jab125 b14c67f
Merge branch 'dev/1.2' of https://github.com/architectury/architectur…
Jab125 c5c0802
don't try add `-XstartOnFirstThread` on legacy forge
Jab125 6c428da
add legacy forge as a mod platform
Jab125 de7a152
Update LoomGradleExtensionAPI.java
Jab125 7523d9a
Update LoomGradleExtension.java
Jab125 2c0b232
check for legacy forge correctly
Jab125 ffa9b5e
only patch forge if it's legacy
Jab125 6093ee9
don't apply native bootstrap on forge
Jab125 e58a86c
intermediary needs to be checked afterwards (TEMPORARY FIX UNTIL IT C…
Jab125 9974672
add 1.12.2 to forge and single jar tests
Jab125 ba304db
Make assertPlatform allow multiple platforms
Jab125 6162d41
todo, fix the legacy forge sources
Jab125 856cd2c
modify more tests
Jab125 037e0ef
Merge branch 'dev/1.2' into fg2/dev/1.2
Jab125 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,4 +173,12 @@ default ForgeProvider getForgeProvider() { | |
|
||
ForgeRunsProvider getForgeRunsProvider(); | ||
void setForgeRunsProvider(ForgeRunsProvider forgeRunsProvider); | ||
|
||
default boolean isLegacyForge() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would want to have old forge as a different platform all together, can’t believe there are much code to share anyways |
||
return isForge() && getForgeUserdevProvider().isLegacyForge(); | ||
} | ||
|
||
default boolean isModernForge() { | ||
return isForge() && !isLegacyForge(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,7 @@ public static void executeAt(Project project, Path input, Path output, AccessTra | |
args.add(output.toAbsolutePath().toString()); | ||
|
||
configuration.apply(args); | ||
project.getLogger().info(args.toString()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
|
||
ForgeToolExecutor.exec(project, spec -> { | ||
spec.getMainClass().set("net.minecraftforge.accesstransformer.TransformerProcessor"); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not want this to be applied by default, pack200 is GPL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPL with the classpath exception (same as OpenJDK), no? So it shouldn't be a problem to my knowledge.