Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set both resources and classes directory to the same directory #179

Closed
wants to merge 1 commit into from

Conversation

shedaniel
Copy link
Member

See this giant commit: MinecraftForge/MinecraftForge@6f9f0f0

MOD_CLASSES is no longer a thing on Forge (mods are detected automatically properly now), we may deprecate that later.

Forge's MDK has this new code:
image

@shedaniel shedaniel requested a review from Juuxel December 8, 2023 13:46
@lukebemish
Copy link

lukebemish commented Dec 10, 2023

Hey, just letting you know - what forge's MDK now does is a really really bad idea gradle wise as it leads to multiple tasks sharing the same output location - which breaks build caching, as well as leading to potential task ordering inconsistencies and general jankiness. It also breaks outright with non java JVM languages. Is it possible to not replicate this anti-pattern in arch loom, or is that impossible due to how arch loom works?

@wagyourtail
Copy link

wagyourtail commented Dec 10, 2023

or is that impossible due to how arch loom works?

it's a problem with how forge now works.

go complain to lexmanos?

@shedaniel shedaniel closed this Dec 10, 2023
@shedaniel shedaniel deleted the feature/forge_1203 branch December 10, 2023 08:30
@Juuxel
Copy link
Member

Juuxel commented Dec 10, 2023

@lukebemish We're aware of that, yeah. I'm developing an alternative solution that doesn't rely on messing up builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants