-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argocd-operator release 0.8.0 #1020
argocd-operator release 0.8.0 #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise
bundle/metadata/annotations.yaml
Outdated
@@ -5,7 +5,7 @@ annotations: | |||
operators.operatorframework.io.bundle.metadata.v1: metadata/ | |||
operators.operatorframework.io.bundle.package.v1: argocd-operator | |||
operators.operatorframework.io.bundle.channels.v1: alpha | |||
operators.operatorframework.io.metrics.builder: operator-sdk-v1.10.0+git | |||
operators.operatorframework.io.metrics.builder: operator-sdk-v1.31.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change
description: Argo CD is a declarative, GitOps continuous delivery tool for Kubernetes. | ||
operators.operatorframework.io/builder: operator-sdk-v1.10.0+git | ||
operators.operatorframework.io/builder: operator-sdk-v1.31.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change.
Please run Looks like your operator-sdk version is v1.31.0. |
ah okay thanks, wasn't sure why that was happening- I think when I switched to my new laptop I just downloaded the latest operator-sdk without thinking about versioning with this. I'll update the PR! |
d6d4649
to
a6f1b98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
944dee0
to
3be18a5
Compare
build/util/Dockerfile
Outdated
# Argo CD v2.8.4 | ||
FROM quay.io/argoproj/argocd@sha256:f02d31d4b115d79de3dc45ebeec3a3107b9178d980e69d9dc2b26019d43f3e09 as argocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use v2.8.5 instead
@reginapizza I would recommend creating an alias for your git commit command so that the signoff is automatically added when you commit using that alias |
3be18a5
to
2a8fc36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks @reginapizza
* upgrade to argocd v2.8.6
What type of PR is this?
What does this PR do / why we need it:
Releases argocd-operator 0.8.0