fix: broken check for context in notificationController #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandrkskd
force-pushed
the
fix-broken-notification-context-check
branch
from
e796502 to
ef16945
Compare
Signed-off-by: Anand Kumar Singh <[email protected]>
anandrkskd
force-pushed
the
fix-broken-notification-context-check
branch
from
ef16945 to
1574590
Compare
svghadi
reviewed
Jan 15, 2025
Signed-off-by: Anand Kumar Singh <[email protected]>
svghadi
reviewed
Jan 17, 2025
svghadi
reviewed
Jan 17, 2025
anandrkskd
force-pushed
the
fix-broken-notification-context-check
branch
from
347604a to
2d270ab
Compare
Signed-off-by: Anand Kumar Singh <[email protected]>
anandrkskd
force-pushed
the
fix-broken-notification-context-check
branch
from
2d270ab to
97274b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR fix the broken check for context fields in notification configmap and notificationConfiguration CR.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes GITOPS-5970
How to test changes / Special notes to the reviewer:
make install runtime="2024-11-21T09:40:54Z" level=info msg="invalidated cache for resource in namespace: argocd-debug with the name: argocd-notifications-cm".