fix: Stabilize on-deployed notification trigger #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <[email protected]>
iam-veeramalla
approved these changes
Jan 6, 2025
|
It will be very challenging to add a test. It requires env setup and also the bug itself is flaky so it will be tricky to write a test. I have tested it manually. The test results are attached in upstream PR. |
|
As discussed on slack, merging this as it is difficult to write tests for this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Fix false positives for on-deployed notifications trigger. Refer argoproj/argo-cd#21333 for more details.
How to test changes / Special notes to the reviewer:
The fix cannot be backported as it depends on a new upstream feature.