fix(argo-cd): Fix required cluster credentials name #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atgane <[email protected]>
atgane
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
Signed-off-by: atgane <[email protected]>
|
Could you please update changelog as well? |
Signed-off-by: atgane <[email protected]>
mkilchhofer
reviewed
Jan 24, 2025
charts/argo-cd/README.md.gotmpl
Outdated
Comment on lines
281
to
284
| ### 7.7.17 | ||
|
|
||
| In clusterCredentials, key is used as the name of the cluster that will be registered in argocd. We have simplified the above condition by removing the require function. | ||
|
|
There was a problem hiding this comment.
Since there is no action required of our chart users, we can remove these lines. We use this chapter in the README only to instruct our users how to upgrade when special action is required.
There was a problem hiding this comment.
Thank you for your reply. I didn't really have anything to write because nothing has changed from the user's perspective, so I appreciate you clearing that up.
Signed-off-by: Marco Maurer <[email protected]>
mkilchhofer
approved these changes
Jan 28, 2025
yu-croco
approved these changes
Jan 28, 2025
mbevc1
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resummit [https://github.com/argoproj/argo-helm/pull/3111]
Fixes #3110
Checklist: