fix: improve getNestedField to fetch field value in objects containing arrays #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the regex breaks the path into segments, handling both dot (.) and bracket ([]) notations - the filter(Boolean) ensures empty strings are excluded Signed-off-by: Dave Canton <[email protected]>
dvcanton
force-pushed
the
fix-nested-form-field
branch
from
6aa2623 to
8bd878c
Compare
|
@agilgur5 @keithchong can you review this? |
13 tasks
|
\review @andrii-korotkov-verkada |
|
agilgur5 has stepped down as a maintainer. I'll take a look, but don't have approvers permission. |
andrii-korotkov-verkada
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
Changed
getNestedFieldfunction in FormField component to parsesrccontaining arrays.