Support OTP 26.x and Elixir 1.15.x in GitHub CI #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - bump apps version in GitHub CI - add additional jobs for more checking - use default job name - cache deps - remove unused dep
kianmeng
commented
Nov 14, 2023
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| name: OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}} |
kianmeng
commented
Nov 14, 2023
| @@ -1,5 +1,4 @@ | |||
| %{ | |||
| "earmark": {:hex, :earmark, "1.3.1", "73812f447f7a42358d3ba79283cfa3075a7580a3a2ed457616d6517ac3738cb9", [:mix], [], "hexpm"}, | |||
There was a problem hiding this comment.
Run mix deps.unlock --check-unused
** (Mix) Unused dependencies in mix.lock file:
* :earmark
Error: Process completed with exit code 1.
kianmeng
commented
Nov 14, 2023
| @@ -8,7 +8,7 @@ defmodule Decorator.Mixfile do | |||
| [ | |||
| app: :decorator, | |||
| version: @version, | |||
| elixir: "~> 1.5", | |||
| elixir: "~> 1.11", | |||
| elixirc_options: elixirrc_options(Mix.env()), | |||
There was a problem hiding this comment.
Minimum supported stable release with security patches is 1.11, see https://hexdocs.pm/elixir/1.15.7/compatibility-and-deprecations.html
kianmeng
commented
Nov 14, 2023
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Elixir | ||
| uses: erlef/setup-beam@v1 |
There was a problem hiding this comment.
Remove extra redirection. See erlef/setup-beam#20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: