Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix permission evaluator API contract to match v4 #90

Merged
merged 6 commits into from
Nov 2, 2023
Merged

fix: Fix permission evaluator API contract to match v4 #90

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27b6768
fix: Or mode no permissions set failure
jasonmcintosh Nov 1, 2023
6cb3216
Changelog
jasonmcintosh Nov 1, 2023
646e153
Set versions a bit higher than 14
jasonmcintosh Nov 1, 2023
4778c5b
fix: Deal with a golang compiler quirk
jasonmcintosh Nov 1, 2023
88410f0
fix: Match the API contract for the permission evaluator
jasonmcintosh Nov 2, 2023
6ace3c3
Merge branch 'master' into fixFiatPermissionEvaluator
jasonmcintosh Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ type ReadPermissable interface {
}

type PermissionsEvaluator interface {
HasReadPermission(user string, rp ReadPermissable) (bool, error)
HasReadPermission(user string, traceparent string, rp ReadPermissable) (bool, error)
}

type FiatClient interface {
Expand Down
Loading