Skip to content

Commit

Permalink
remore trailing slash for overrideUrlName
Browse files Browse the repository at this point in the history
  • Loading branch information
jordiprats committed Mar 18, 2021
1 parent c183db0 commit 55200da
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/deploy/spindeploy/expose_service/transform.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ func (t *exposeTransformer) setStatusAndOverrideBaseUrl(ctx context.Context, ser
// findStatusUrl returns the overrideBaseUrl or load balancer url, indicating if it came from overrideBaseUrl
func (t *exposeTransformer) findStatusUrl(ctx context.Context, serviceName string, overrideUrlName string) (string, bool, error) {
// ignore error, overrideBaseUrl may not be set in hal config
if strings.HasSuffix(overrideUrlName, "/") {
overrideUrlName = overrideUrlName[:len(overrideUrlName) - 1]
}
statusUrl, _ := t.svc.GetSpinnakerConfig().GetHalConfigPropString(ctx, overrideUrlName)
if statusUrl != "" {
return statusUrl, true, nil
Expand Down

0 comments on commit 55200da

Please sign in to comment.