Various minor fixes #238
Closed
Various minor fixes #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping quality variables was made signed to handle correctly erroneous input.
| @@ -148,7 +148,7 @@ std::FILE* BedSplit::saveFileChunk(std::string& filename,size_t file_index) | |||
|
|
|||
| char tmp[10]; | |||
| filename.assign(this->outfileprefix); | |||
| sprintf(tmp,"%05d",(file_index+1)); | |||
| sprintf(tmp,"%05lu",(file_index+1)); | |||
There was a problem hiding this comment.
%05zu; but probably it would be best to just avoid the issue by building the filename via an ostringstream.
There was a problem hiding this comment.
Thanks, I fixed it in f9001c5.
|
PR #233 has a better fix for the overflow warning that makes |
|
Thanks all. We will try to merge in all of these patches soon. |
The `abs` function calls were replaced with `labs` for long int variables.
In addition to 50d8c16.
If modification time of a FASTA index file is less than modification time of its FASTA file, then the warning message is shown; resolves #228.
gtamazian
changed the title
To make the test more robust, the original FASTA file is replaced with another one with the same sequences but different headers. I used the example by @dshivak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes were motivated by the clang C++ compiler warnings.