Merge pull request #13956 from artsy/DIA-664-dark-mode-q-a--part-2

fix(DIA-664): Dark mode Q/A - Part 2
artsy · Jun 4, 2024 · d482c67 · d482c67
2 parents 6f1a7fb + 92de69e
commit d482c67
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 19 deletions.
diff --git a/src/Apps/About/AboutApp.tsx b/src/Apps/About/AboutApp.tsx
@@ -14,10 +14,7 @@ import { MetaTags } from "Components/MetaTags"
 import { RouterLink } from "System/Router/RouterLink"
 import { resized } from "Utils/resized"
 import { AboutArtworksRailQueryRenderer } from "./AboutArtworksRail"
-import {
-  FullBleedHeader,
-  FullBleedHeaderOverlay,
-} from "Components/FullBleedHeader/FullBleedHeader"
+import { FullBleedHeader } from "Components/FullBleedHeader/FullBleedHeader"
 
 export const AboutApp: React.FC = () => {
   return (
@@ -33,10 +30,16 @@ export const AboutApp: React.FC = () => {
         caption="Detail of Cassi Namoda, A Strange Song, 2022. Detail of Alex Katz,
             Day Lily 1, 1969."
       >
-        <FullBleedHeaderOverlay
+        <Flex
+          position="absolute"
+          top={0}
+          left={0}
+          width="100%"
+          height="100%"
           alignItems="center"
           justifyContent={["center", "flex-start"]}
           p={4}
+          zIndex={1}
         >
           <Text
             variant={["xl", "xxl"]}
@@ -46,7 +49,7 @@ export const AboutApp: React.FC = () => {
           >
             The Future of Art Collecting
           </Text>
-        </FullBleedHeaderOverlay>
+        </Flex>
       </FullBleedHeader>
 
       <Spacer y={4} />

diff --git a/src/Apps/Consign/Routes/MarketingLanding/Components/LandingPage/MeetTheSpecialists.tsx b/src/Apps/Consign/Routes/MarketingLanding/Components/LandingPage/MeetTheSpecialists.tsx
@@ -90,19 +90,25 @@ export const MeetTheSpecialists: React.FC = () => {
                   lazyLoad
                   alt={`specialist ${i.firstName}`}
                 />
-                <LinearGradient />
 
-                <Box position="absolute" width="100%">
+                <Info position="absolute" width="100%" pt={12}>
                   <Box pl={2} pr={2} zIndex={10}>
                     <Text variant={["lg-display", "xl"]} color="white100">
                       {i.name}
                     </Text>
+
                     <Text mb={1} variant={["xs", "xs"]} color="white100">
                       {i.jobTitle}
                     </Text>
-                    <Text mb={2} variant={["xs", "sm"]} color="white100">
+
+                    <Text
+                      mb={2}
+                      variant={["xs", "sm-display"]}
+                      color="white100"
+                    >
                       <ReadMore content={i.bio} maxChars={88} />
                     </Text>
+
                     <Button
                       // @ts-ignore
                       as={RouterLink}
@@ -116,7 +122,7 @@ export const MeetTheSpecialists: React.FC = () => {
                       Contact {i.firstName}
                     </Button>
                   </Box>
-                </Box>
+                </Info>
               </Box>
             </ResponsiveBox>
           ))
@@ -142,13 +148,7 @@ export const MeetTheSpecialists: React.FC = () => {
   )
 }
 
-const LinearGradient = styled(Box)`
-  position: "absolute";
-  top: 0;
-  width: 100%;
-  height: 100%;
-  background: transparent;
-  position: absolute;
-  transition: background-color 200ms;
+const Info = styled(Box)`
   background: ${themeGet("effects.overlayGradient")};
+  text-shadow: ${themeGet("effects.textShadow")};
 `
diff --git a/src/Components/Footer/FooterDownloadAppBanner.tsx b/src/Components/Footer/FooterDownloadAppBanner.tsx
@@ -25,7 +25,7 @@ import { useSystemContext } from "System/SystemContext"
 const IGNORE_PATHS = ["/meet-your-new-art-advisor"]
 
 const APP_BANNER_SRC =
-  "https://files.artsy.net/images/universal-footer_april-14.jpg"
+  "https://files.artsy.net/images/universal-footer_april-14_cropped.jpg"
 
 export const FooterDownloadAppBanner = () => {
   const { relayEnvironment } = useSystemContext()