feat(dia-1038): infinite discovery - make initial arworks batch index configurable #6328
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egdbear
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
This seems ✅ to me. In addition to a daily job for indexing only new artworks (I believe we can reuse the existing Zenith infinite_discovery job), we will also need a weekly job to update the initial collection for cold-start users. I think we can parameterize the existing job and have both jobs scheduled to run. /cc @cavvia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@egdbear let me know what you think. I suppose we may want to experiment with different initial artwork datasets in future, and I think it will be easy if
discoverArtworksquery field has an option to specify which artworks collection to use. For now, I've indexed Most Loved, Street Art, and New this Week marketing collections to theinfinite_discovery_initial_artworksindex (zenith PR to come).