Fix to detect uBlock Origin #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Would like to see this change added. Noticed that we are failing to detect because of this. |
aruniverse
reviewed
Dec 13, 2023
| }).then(({ redirected }) => { | ||
| if (redirected) setAdBlockDetected(true); | ||
| }) | ||
| .catch(() => { |
There was a problem hiding this comment.
sorry nit: could you format the code here
|
changes copied into #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uBlock Origin doesn't "block" calls, but redirects them with a 307 redirect. So the request will never fail. This way, the catch block will never run, and
adBlockDetectedwill never be true.With my changes, the request will check if the responses is redirected. If so, set adBlockDetected to true.