Add option to set the domain of the SOI cookie #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is solving an issue that we are currently facing, any chance this can be merged in ? |
phogel
reviewed
Apr 20, 2022
| // decoded consent data must not be written to the cookie | ||
| delete value.consentData; | ||
| Cookie.set(name, value, { expires: expires_in_days }); | ||
| Cookie.set(name, value, { expires: expires_in_days, domain: domain }); |
There was a problem hiding this comment.
Before i merge this, what happens when domain is an empty string? Would it perhaps be better to leave out the domain parameter altogether in that case?
There was a problem hiding this comment.
Oh nevermind my write access was revoked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased pull-request of #244 from @cphilleo.
The Problem
Multiple sites on sub-domains would like to share consent, e.g.
sub1.example.com,sub2.example.com,sub3.example.com. This can be achieved by using the POI feature and specifying a common domain such asconsent.example.comhowever there is overhead of at least 20K per page load to use POI.Proposal
Since subdomains can set a shared cookie on the parent domain, it's more efficient to allow the SOI cookie to be set on the parent domain, and then be shared by all subdomains. This would be a form of group consent.
This pull request adds an option to set the domain to be used for the SOI cookie. Setting the cookie to an invalid non-parent domain results in no cookie being set.