New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings #2

Open

DemonInTheCloset wants to merge 2 commits into asahilina:main from DemonInTheCloset:fix_clippy_warnings

Contributor

DemonInTheCloset commented Sep 11, 2022

Mostly unused template args/dead code warnings.

GPUArray contains a Boxed Vec, this makes little sense, as a Vec is already a ptr to an array on the heap, so the double indirection is undesireable.

struct GPUArray<T: Copy> {
    raw: Box<Vec<T>>,
    gpu_ptr: NonZeroU64,
}

DemonInTheCloset added 2 commits

September 11, 2022 16:50


          fix(clippy): Fix Simple clippy warnings

05ca218


          fix(boxed_vec): Generally a Vec shouldn't be boxed

b5f272f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet